RFR: 8283094: Add Ideal transformation: x + (con - y) -> (x - y) + con [v3]
Zhiqiang Zang
duke at openjdk.java.net
Mon Mar 21 23:25:21 UTC 2022
On Mon, 21 Mar 2022 14:06:04 GMT, Quan Anh Mai <duke at openjdk.java.net> wrote:
>> Zhiqiang Zang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> move tests to existing test classes.
>
> test/hotspot/jtreg/compiler/c2/irTests/TestIRAddIdealXPlus_ConMinusY_.java line 36:
>
>> 34: * @run driver compiler.c2.irTests.TestIRAddIdealXPlus_ConMinusY_
>> 35: */
>> 36: public class TestIRAddIdealXPlus_ConMinusY_ {
>
> Could you consider putting this in [SubINodeIdealizationTests](https://github.com/openjdk/jdk/blob/d24b6754a216c6d8b4d2fd1154dcf62d9e2c6c46/test/hotspot/jtreg/compiler/c2/irTests/SubINodeIdealizationTests.java) instead. Also I think it would be preferrable to have another PR to move the likes of [TestSpecialCasesOf_AMinusB_Plus_CMinusD_InAddIdeal](https://github.com/openjdk/jdk/blob/d24b6754a216c6d8b4d2fd1154dcf62d9e2c6c46/test/hotspot/jtreg/compiler/c2/irTests/TestSpecialCasesOf_AMinusB_Plus_CMinusD_InAddIdeal.java) to the corresponding group. Thanks.
Done. Thanks. I created a new PR #7897 for moving [TestSpecialCasesOf_AMinusB_Plus_CMinusD_InAddIdeal](https://github.com/openjdk/jdk/blob/d24b6754a216c6d8b4d2fd1154dcf62d9e2c6c46/test/hotspot/jtreg/compiler/c2/irTests/TestSpecialCasesOf_AMinusB_Plus_CMinusD_InAddIdeal.java).
-------------
PR: https://git.openjdk.java.net/jdk/pull/7795
More information about the hotspot-compiler-dev
mailing list