RFR: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails [v2]
Roland Westrelin
roland at openjdk.java.net
Tue Mar 22 12:18:22 UTC 2022
> IdealLoopTree::policy_unroll_slp_analysis() restricts unrolling of
> loops that are found to be candidate for superword but if superword
> then fails, unrolling doesn't always resume. SuperWord::output() has
> logic for that in one of the failure paths but some other paths are
> not covered (for instance in the case of the test case). I propose
> that superword explictly returns whether it succeeded or not and that
> in case of failure, for a main loop, unrolling be attempted again.
Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
Update test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java
Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7822/files
- new: https://git.openjdk.java.net/jdk/pull/7822/files/9941937d..cac6704b
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7822&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7822&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/7822.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7822/head:pull/7822
PR: https://git.openjdk.java.net/jdk/pull/7822
More information about the hotspot-compiler-dev
mailing list