RFR: 8281429: PhiNode::Value() is too conservative for tripcount of CountedLoop [v2]

[Roland Westrelin]

On Tue, 22 Mar 2022 09:35:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/cfgnode.cpp line 1111:
> 
>> 1109:         const TypeInteger* stride_t = phase->type(stride)->isa_integer(l->bt());
>> 1110:         if (lo != NULL && hi != NULL && stride_t != NULL) { // Dying loops might have TOP here
>> 1111:           assert(stride_t->hi_as_long() == stride_t->lo_as_long(), "bad stride type");
> 
> Should we simply check `stride_t->is_con()` here?

right.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7823