RFR: 8283422: Create a new test for JDK-8254790

[Sergey Bylokhov]

On Tue, 22 Mar 2022 15:15:39 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> The [JDK-8254790](https://bugs.openjdk.java.net/browse/JDK-8254790) initially was reported on macOS.
>> It was found by the "javax/xml/crypto/dsig/GenerationTests.java" test which for some reason worked fine on Linux/Windows most? of the time.
>> 
>> I tried to run that test on Linux/Windows many times on a few systems and it always pass. Also, I got the same result for the tier1...tier4 tests.
>> 
>> I have found that the easiest way to reproduce the crash is to pass the result of the string.indexOf to the str.charAt when the heap is big enough. The test below[1] trigger the crash 1000 time in a row on win/lin on systems I have tested.
>> 
>> I am not sure what is the best way to contribute to the test, should I create a stand-alone test like[1], or update an existing test as I did for the first version of this PR?
>> 
>> [1]:
>> 
>> package compiler.intrinsics.string;
>> 
>> import static jdk.test.lib.Asserts.assertTrue;
>> 
>> public final class TestStringIndexOfLargeHeap {
>>     static final int[] data = new int[Integer.MAX_VALUE / 2];
>>     public static void main(String[] args) throws Exception {
>>         test('a');
>>         test('\ubeef');
>>     }
>>     private static void test(char ch) {
>>         String str = ("0123456789" + ch).repeat(100);
>>         for (int i = 0; i < 1_000_000; ++i) {
>>             assertTrue(ch == str.charAt(str.indexOf(ch)));
>>         }
>>     }
>> }
>
> The test fails in our CI with:
> 
> 
> java.lang.OutOfMemoryError: Java heap space
> 	at compiler.intrinsics.string.TestStringIntrinsics2.main(TestStringIntrinsics2.java:142)
> 	at java.base/java.lang.invoke.LambdaForm$DMH/0x0000000801002800.invokeStatic(LambdaForm$DMH)
> 	at java.base/java.lang.invoke.LambdaForm$MH/0x0000000801003c00.invoke(LambdaForm$MH)
> 	at java.base/java.lang.invoke.Invokers$Holder.invokeExact_MT(Invokers$Holder)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invokeImpl(DirectMethodHandleAccessor.java:155)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.base/java.lang.Thread.run(Thread.java:828)

@TobiHartmann Thank you for your feedback, the trace shows that the test fails to allocate the FILL_HEAP = new int[Integer.MAX_VALUE / 2]; when the heap is set to 5G.  I can increase the "-mx" option, but probably the root cause of the OOM is something different, the "git actions" are green, the test is also green when I run it multiple times. Probably mach5 adds some additional options to the test execution?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7883