RFR: 8283408: Fix a C2 crash when filling arrays with unsafe [v2]

[Pengfei Li]

On Tue, 22 Mar 2022 08:09:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a few comments
>
> src/hotspot/share/opto/loopTransform.cpp line 4050:
> 
>> 4048:   // AddP node adding an absolute offset, so we do a NULL check here.
>> 4049:   if (offset != NULL) {
>> 4050:     from = new AddPNode(base, from, offset);
> 
> Is it worth adding an `C->has_unsafe_access()` assert here?

An assertion is added in new commit. Thanks for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7884