RFR: 8283519: Hsdis with capstone should annotate output

Jorn Vernee jvernee at openjdk.java.net
Wed Mar 23 12:18:33 UTC 2022


On Tue, 22 Mar 2022 15:20:38 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Sample output after the changes:
> 
> [Stub Code]
>   0x000001cd0a937e20:   nopl		(%rax, %rax)        ;   {no_reloc}
>   0x000001cd0a937e25:   movabsq		$0x0, %rbx          ;   {static_stub}
>   0x000001cd0a937e2f:   jmp		0x1cd0a937e2f       ;   {runtime_call}
> [Exception Handler]
>   0x000001cd0a937e34:   callq		0x1cd0a3ca480       ;   {runtime_call handle_exception_from_callee Runtime1 stub}
>   0x000001cd0a937e39:   movabsq		$0x7ff8df21a850, %rcx;   {external_word}
>   0x000001cd0a937e43:   andq		$0xfffffffffffffff0, %rsp
>   0x000001cd0a937e47:   movabsq		$0x7ff8deef30c0, %r10;   {runtime_call MacroAssembler::debug64}
>   0x000001cd0a937e51:   callq		*%r10
>   0x000001cd0a937e54:   hlt		
> [Deopt Handler Code]
>   0x000001cd0a937e55:   movabsq		$0x1cd0a937e55, %r10;   {section_word}
>   0x000001cd0a937e5f:   pushq		%r10
>   0x000001cd0a937e61:   jmp		0x1cd0a325ca0       ;   {runtime_call DeoptimizationBlob}
>   0x000001cd0a937e66:   hlt		
>   0x000001cd0a937e67:   hlt		
> 
> before the changes none of the annotations (like `[Stub Code]` or `;   {no_reloc}`) were present.

LGTM

-------------

Marked as reviewed by jvernee (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7904


More information about the hotspot-compiler-dev mailing list