RFR: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails [v4]
Tobias Hartmann
thartmann at openjdk.java.net
Thu Mar 24 09:36:42 UTC 2022
On Wed, 23 Mar 2022 16:41:14 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> IdealLoopTree::policy_unroll_slp_analysis() restricts unrolling of
>> loops that are found to be candidate for superword but if superword
>> then fails, unrolling doesn't always resume. SuperWord::output() has
>> logic for that in one of the failure paths but some other paths are
>> not covered (for instance in the case of the test case). I propose
>> that superword explictly returns whether it succeeded or not and that
>> in case of failure, for a main loop, unrolling be attempted again.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>
> test fix on x86
Looks good.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7822
More information about the hotspot-compiler-dev
mailing list