RFR: 8283641: Large value for CompileThresholdScaling causes assert [v2]

[Ioi Lam]

On Thu, 24 Mar 2022 17:42:01 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @vnkozlov comment: no need to check for min_intx
>
> src/hotspot/share/compiler/compilerDefinitions.cpp line 133:
> 
>> 131:     if (v > max_intx) {
>> 132:       return max_intx;
>> 133:     } else if (v < min_intx) {
> 
> This check is meaningless since `v` can't be negative. If you want you can add assert.

I removed the `min_intx` check and added the asserts. I ran with the following tests and it didn't trigger the asserts. I'll rerun tiers 1-3 again.


java -XX:CompileThreshold=-1         -XX:CompileThresholdScaling=1 -version
java -XX:Tier0InvokeNotifyFreqLog=-2 -XX:CompileThresholdScaling=1 -version
java -XX:Tier4BackEdgeThreshold=-2   -XX:CompileThresholdScaling=1 -version

-------------

PR: https://git.openjdk.java.net/jdk/pull/7944