RFR: 8282547: IGV: add control-flow graph view [v2]

[Christian Hagedorn]

On Wed, 23 Mar 2022 08:24:11 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/Connection.java line 38:
>> 
>>> 36:     }
>>> 37: 
>>> 38:     public ConnectionStyle getStyle();
>> 
>> `public` is implied for interface methods and does not need to be stated explicitly.
>
> I declared it explicitly as `public` for consistency with the rest of the IGV project. Updating all interfaces would be better addressed in a separate cleanup RFE, I think.

I agree, better change it all together in one go and keep the consistency for now.

>> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/FigureConnection.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2008, 2022, Oracle and/or its affiliates. All rights reserved.
>> 
>> Should only be 2022 for a new file.
>
> This file is not really new, only renamed from the old `Connection.java` and slightly updated, hence I think it makes sense to leave the original initial year.

Okay, then it's fine.

>> src/utils/IdealGraphVisualizer/ServerCompiler/src/main/resources/com/sun/hotspot/igv/servercompiler/filters/hideExceptionBlocks.filter line 4:
>> 
>>> 2: 
>>> 3: var f = new RemoveBlockFilter("Hide exception blocks");
>>> 4: f.addRule(
>> 
>> Could the rule object directly be passed to the constructor instead of going over `addRule()`? On top of that, all filters follow the pattern "create f + `f.apply(graph)`". This could be moved into a single method to simplify filters. But this would exceed the scope of this change and could be done in a separate RFE.
>
> A filter can consist of multiple rules, see e.g. `ServerCompiler/src/main/resources/com/sun/hotspot/igv/servercompiler/filters/structural.filter`, so I think it makes sense to pass them separately. What could be done to reduce this complexity is to define more helper methods in `Filter/src/main/resources/com/sun/hotspot/igv/filter/helper.js`. As you suggest, I think this would be best done for all filters at once in a separate RFE.

Ah I see, I missed that. That would be a good option to provide more helper functions in an RFE to simplify the creation of new user filters.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7817