RFR: 8282547: IGV: add control-flow graph view [v2]

[Roberto Castañeda Lozano]

On Fri, 25 Mar 2022 10:02:15 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> > Thanks Christian for reviewing and providing so many suggestions! I have implemented all of them except a few for which I have provided separate answers.
> 
> Thanks for coming back with the updates - they look good!
> 
> > This is actually deliberate, I thought it would be useful to preserve the control-flow context, so that the user can at all times know e.g. whether a block she is looking at is within a loop.
> 
> I see that this can be valuable.
> 
> > Having said that, I agree that sometimes, particularly for large graphs, it would be useful to hide the empty blocks. This behavior would also be more consistent with the clustered sea-of-nodes view.
> 
> Yes, that was the problem I was experiencing when I was testing your new change with such a large graph. Among hundreds of empty blocks, the actually selected nodes were too widely spread such that the view became hard to use.
> 
> > Would it make sense to add a toolbar button to hide/show empty blocks in the control-flow graph view? If you think so, I will create a RFE to do that separately.
> 
> I think that would be great, thanks for considering it :-) And as you've mentioned above, for small graphs it helps to show the empty blocks as well. So, a toggle button would be a good choice.
> 
> Thanks, Christian

Thanks again for reviewing! I just addressed your latest comment, will file a RFE for hiding/showing empty blocks as soon as this PR gets a second approval.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7817