RFR: 8282547: IGV: add control-flow graph view [v3]

[Roberto Castañeda Lozano]

On Mon, 28 Mar 2022 03:36:16 GMT, Xin Liu <xliu at openjdk.org> wrote:

> This looks good to me. I am not a reviewer. I even don't think I understand IGV completely. I just read the patch and also try it out. I think this compact view of sea-of-node is really useful.

Thanks for having a look at the changes and trying out the new view, Xin, happy that you found it useful!

> src/utils/IdealGraphVisualizer/ServerCompiler/src/main/java/com/sun/hotspot/igv/servercompiler/ServerCompilerScheduler.java line 61:
> 
>> 59:             inputNode = n;
>> 60:             String p = n.getProperties().get("is_block_proj");
>> 61:             isBlockProjection = (p != null && p.equals("true"));
> 
> is it easy to flip equals here? 
> "true".equals(p) can avoid nullcheck.

Thanks for the tip! String comparisons are not a performance bottleneck in graph scheduling, and I find the current code more readable. But I will re-evaluate this suggestion after the main performance bottleneck in scheduling is removed in [JDK-8282043](https://bugs.openjdk.java.net/browse/JDK-8282043).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7817