RFR: 8283494: Factor out calculation of actual number of XMM registers [v2]
Thomas Schatzl
tschatzl at openjdk.java.net
Wed Mar 30 09:28:42 UTC 2022
On Tue, 29 Mar 2022 22:34:13 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Put method implementation in hpp file
>
> src/hotspot/cpu/x86/register_x86.hpp line 169:
>
>> 167: // Actually available XMM registers for use, depending on actual CPU capabilities
>> 168: // and flags.
>> 169: static int available_xmm_registers();
>
> Why not define function's body here?
I do not think its use is performance critical considering its use in the surrounding code then that goes on and does something per xmm register.
There is no strong opinion from me about this, so I moved it to the hpp file. Build times do not significantly change afaict.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7917
More information about the hotspot-compiler-dev
mailing list