RFR: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled

Tobias Hartmann thartmann at openjdk.java.net
Mon May 2 07:51:42 UTC 2022


On Mon, 2 May 2022 01:53:57 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> Several tests in compiler/c2/irTests fail if C2 is not available.
> 
> The following 7 tests use C2-only VM falgs.
> 
> compiler/c2/irTests/TestSkeletonPredicates.java
> compiler/c2/irTests/TestFewIterationsCountedLoop.java
> compiler/c2/irTests/TestDuplicateBackedge.java
> compiler/c2/irTests/TestStripMiningDropsSafepoint.java
> compiler/c2/irTests/TestCountedLoopSafepoint.java
> compiler/c2/irTests/TestLongRangeChecks.java
> compiler/c2/irTests/TestSuperwordFailsUnrolling.java
> 
> 
> The following two tests assert that C2 must be available.
> 
> compiler/c2/irTests/TestIRLShiftIdeal_XPlusX_LShiftC.java   
> compiler/c2/irTests/TestIRAddIdealNotXPlusC.java
> 
> 
> It would be better to add `@requires vm.compiler2.enabled` to these tests.
> 
> Thanks.
> Best regards,
> Jie

Looks good and trivial.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8495


More information about the hotspot-compiler-dev mailing list