RFR: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java

Jie Fu jiefu at openjdk.java.net
Mon May 2 14:16:03 UTC 2022


Hi all,

The four test configurations for `compiler/stable/TestStableShort.java` are the same.

/*
 * @test TestStableShort
 * @summary tests on stable fields and arrays
 * @library /test/lib /
 * @modules java.base/jdk.internal.misc
 * @modules java.base/jdk.internal.vm.annotation
 * @build sun.hotspot.WhiteBox
 *
 * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
 *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
 *                                 -XX:-TieredCompilation
 *                                 -XX:+FoldStableValues
 *                                 compiler.stable.TestStableShort
 * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
 *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
 *                                 -XX:-TieredCompilation
 *                                 -XX:+FoldStableValues
 *                                 compiler.stable.TestStableShort
 *
 * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
 *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
 *                                 -XX:-TieredCompilation
 *                                 -XX:+FoldStableValues
 *                                 compiler.stable.TestStableShort
 * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
 *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
 *                                 -XX:-TieredCompilation
 *                                 -XX:+FoldStableValues
 *                                 compiler.stable.TestStableShort
 */


I believe this is a copy-paste mistake.
Let's fix it.

The patch just follows the test configurations in TestStable{Byte/Char/Int/Long/Float/Double/Object}.java

Thanks.
Best regards,
Jie

-------------

Commit messages:
 - 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java

Changes: https://git.openjdk.java.net/jdk/pull/8503/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8503&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286013
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8503.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8503/head:pull/8503

PR: https://git.openjdk.java.net/jdk/pull/8503


More information about the hotspot-compiler-dev mailing list