RFR: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java

[Jie Fu]

On Mon, 2 May 2022 14:35:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi all,
>> 
>> The four test configurations for `compiler/stable/TestStableShort.java` are the same.
>> 
>> /*
>>  * @test TestStableShort
>>  * @summary tests on stable fields and arrays
>>  * @library /test/lib /
>>  * @modules java.base/jdk.internal.misc
>>  * @modules java.base/jdk.internal.vm.annotation
>>  * @build sun.hotspot.WhiteBox
>>  *
>>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>>  *                                 -XX:-TieredCompilation
>>  *                                 -XX:+FoldStableValues
>>  *                                 compiler.stable.TestStableShort
>>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>>  *                                 -XX:-TieredCompilation
>>  *                                 -XX:+FoldStableValues
>>  *                                 compiler.stable.TestStableShort
>>  *
>>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>>  *                                 -XX:-TieredCompilation
>>  *                                 -XX:+FoldStableValues
>>  *                                 compiler.stable.TestStableShort
>>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>>  *                                 -XX:-TieredCompilation
>>  *                                 -XX:+FoldStableValues
>>  *                                 compiler.stable.TestStableShort
>>  */
>> 
>> 
>> I believe this is a copy-paste mistake.
>> Let's fix it.
>> 
>> The patch just follows the test configurations in TestStable{Byte/Char/Int/Long/Float/Double/Object}.java
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Yes, this looks like a copy-paste error.

Thanks @shipilev and @TobiHartmann for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8503