RFR: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc [v2]

Emanuel Peter duke at openjdk.java.net
Tue May 3 07:00:55 UTC 2022


On Mon, 2 May 2022 20:36:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comments adapted to review
>
> src/hotspot/share/opto/chaitin.cpp line 1732:
> 
>> 1730:           } else {
>> 1731:             // In some rare cases:
>> 1732:             // There is no space reserved for a memory edge before the inputs.
> 
> It sounds like random case but you have very specific case: Mach instructions which uses `stackSlotX`. I think these 2 lines should say that. Something like:
> 
> // There is no space reserved for a memory edge before the inputs for
> // instructions which have "stackSlotX" parameter instead of "memory".
> // For example, "MoveF2I_stack_reg".

@vnkozlov thanks for the suggestion, I put it in.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7889


More information about the hotspot-compiler-dev mailing list