RFR: 8285976: compiler/exceptions/OptimizeImplicitExceptions.java can't pass with -XX:+DeoptimizeALot

Tobias Hartmann thartmann at openjdk.java.net
Tue May 3 15:54:20 UTC 2022


On Tue, 3 May 2022 15:36:36 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Disable DeoptimizeALot and DeoptimizeRandom, 2 develop options when run this test for stability.
>
> test/hotspot/jtreg/compiler/exceptions/OptimizeImplicitExceptions.java line 200:
> 
>> 198:         // The following options are both develop, getBooleanVMFlag() returns NULL in product build.
>> 199:         // If they are set in debug build, disable them for more test stability.
>> 200:         if (WB.getBooleanVMFlag("DeoptimizeALot")) {
> 
> If this really returns NULL in a product build, wont this cause an exception then?
> 
> Wouldn't it be easier to just unconditionally set them both to false:
> 
> WB.setBooleanVMFlag("DeoptimizeALot", false);
> WB.setBooleanVMFlag("DeoptimizeRandom", false);

If so, I think that should be done in the `@run` statement.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8513


More information about the hotspot-compiler-dev mailing list