RFR: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc [v3]

Tobias Hartmann thartmann at openjdk.java.net
Wed May 4 06:04:15 UTC 2022


On Wed, 4 May 2022 05:12:24 GMT, Emanuel Peter <duke at openjdk.java.net> wrote:

>> src/hotspot/share/opto/chaitin.cpp line 1736:
>> 
>>> 1734:             // src to cisc, else we might schedule cisc before src, loading from a
>>> 1735:             // spill location before storing the spill.
>>> 1736:             cisc->add_prec(src);
>> 
>> An assertion for null memory operand can be added before adding presidence edge.
>
> @jatin-bhateja Thanks, I added it :)

`memory_operand()` returns a `MachOper*`, we should not compare it to `0` but to `nullptr` (see https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7889


More information about the hotspot-compiler-dev mailing list