RFR: 8282218: C1: Missing side effects of dynamic class loading during constant linkage [v2]

[Vladimir Ivanov]

On Thu, 24 Feb 2022 19:52:57 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - helper method to access constant pool tag
>>  - Merge branch 'master' into 8282218.c1.class_loading
>>  - 8282218: C1: Missing side effects of dynamic class loading during constant linkage
>
> src/hotspot/share/ci/ciStreams.hpp line 258:
> 
>> 256: 
>> 257:     int index = get_constant_pool_index();
>> 258:     constantTag tag = get_raw_pool_tag(index);
> 
> Looks like these lines are the same as in `is_dynamic_constant()`. Can you move them in separate method to avoid duplication?

Ok, I introduced a no-arg `get_raw_pool_tag()` helper method. Does it look better?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7612