RFR: 8286179: Node::find(int) should not traverse from new to old nodes [v2]
Emanuel Peter
duke at openjdk.java.net
Mon May 9 10:11:39 UTC 2022
On Fri, 6 May 2022 15:59:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added nullprt check for old_root
>
> src/hotspot/share/opto/node.cpp line 1616:
>
>> 1614: // Call this from debugger, search in old nodes:
>> 1615: Node* find_old_node(const int idx) {
>> 1616: return old_root()->find(idx);
>
> Need check for `nullptr` for `old_root()` call and may be do nothing since we will get message already.
Thanks @vnkozlov I added an assert
> src/hotspot/share/opto/node.cpp line 1631:
>
>> 1629: // Call this from debugger, search in old nodes:
>> 1630: Node* find_old_ctrl(const int idx) {
>> 1631: return old_root()->find_ctrl(idx);
>
> Need `nullptr` check.
done.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8567
More information about the hotspot-compiler-dev
mailing list