RFR: 8286339: compiler/c2/irTests/TestEnumFinalFold.java fails if Enum/String methods are not inlined

Tue May 10 08:49:49 UTC 2022

On Tue, 10 May 2022 08:11:12 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> As shown in the bug, the test relies on test methods in `Enum` and `String` to be inlined for constant folding to happen. In some testing modes, this does not happen. The fix is to force inlining for methods that test uses. It is kinda odd to ask force inlining of system class methods, but it does not seem problematic.
> 
> Additional testing:
>  - [x] Test now passes in unusual test modes reported
>  - [x] Test still passes in default test modes on x86_32 and x86_64

I think many of our tests would fail with such invasive flag values. I don't think we can/should guard against all possible combinations of VM flags.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8625