RFR: 8286339: compiler/c2/irTests/TestEnumFinalFold.java fails if Enum/String methods are not inlined

Jie Fu jiefu at openjdk.java.net
Tue May 10 14:57:06 UTC 2022


On Tue, 10 May 2022 12:16:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> > There are more than 100 tests under `hotspot/jtreg/compiler`, which `* @requires vm.flagless`. Many of them seems to be added recently.
> 
> There are no flagless tests in `compiler/c2/irTests`, though. AFAIU, the intent for `vm.flagless` is to skip non-default run configurations for the tests which are driven internally with _complete overwrite_ of passed test options. In other words, `vm.flagless` is there to mark the tests where putting different VM options on the driver code does not really affect the test. IR tests are not like this, so `vm.flagless` makes little sense there. (One can imagine putting more compiler stress options to TEST_VM_OPTS...)

Thanks @shipilev for your explanation.

I didn't try if the test would fail with something like `-XX:-Inline`.
If it may fail, why not make it to be more robust by just adding `vm.flagless`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8625


More information about the hotspot-compiler-dev mailing list