RFR: 8283689: Update the foreign linker VM implementation [v7]
Vladimir Ivanov
vlivanov at openjdk.java.net
Tue May 10 21:06:20 UTC 2022
On Mon, 28 Mar 2022 12:15:10 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded ComputeMoveOrder
>> - Remove comment about native calls in lcm.cpp
>> - 8284072: foreign/StdLibTest.java randomly crashes on MacOS/AArch64
>>
>> Reviewed-by: jvernee, mcimadamore
>> - Update riscv and arm stubs
>> - Remove spurious ProblemList change
>> - Pass pointer to LogStream
>> - Polish
>> - Replace TraceNativeInvokers flag with unified logging
>> - Fix other platforms, take 2
>> - ... and 11 more: https://git.openjdk.java.net/jdk/compare/3c88a2ef...43fd1b91
>
> src/hotspot/share/utilities/growableArray.hpp line 151:
>
>> 149: return _data;
>> 150: }
>> 151:
>
> This accessor is added to be able to temporarily view a stable GrowableArray instance as a C-style array. It is used to by `NativeCallConv` and `RegSpiller` in `foreign_globals.hpp`.
>
> GrowableArray already has an `adr_at` accessor that does something similar, but using `adr_at(0)` fails on empty growable arrays since it also performs a bounds check. So it can not be used.
Any problems with migrating `CallConv` and `RegSpiller`away from ` VMReg* + int` to `GrowableArray<VMReg>`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7959
More information about the hotspot-compiler-dev
mailing list