RFR: 8283689: Update the foreign linker VM implementation [v7]

[Jorn Vernee]

On Tue, 10 May 2022 21:02:39 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:
>> 
>>  - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>>  - Remove unneeded ComputeMoveOrder
>>  - Remove comment about native calls in lcm.cpp
>>  - 8284072: foreign/StdLibTest.java randomly crashes on MacOS/AArch64
>>    
>>    Reviewed-by: jvernee, mcimadamore
>>  - Update riscv and arm stubs
>>  - Remove spurious ProblemList change
>>  - Pass pointer to LogStream
>>  - Polish
>>  - Replace TraceNativeInvokers flag with unified logging
>>  - Fix other platforms, take 2
>>  - ... and 11 more: https://git.openjdk.java.net/jdk/compare/3c88a2ef...43fd1b91
>
> Nice work! Looks good. Some minor comments/questions follow.

@iwanowww Thanks for the review! I've addressed most comments already, but will have to think a bit on how to handle the asynchronous exceptions issue.

> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5531:
> 
>> 5529: }
>> 5530: 
>> 5531: // On 64 bit we will store integer like items to the stack as
> 
> Time for a cleanup? `64 bit` vs `64bit`, `abi`, `Aarch64`.

I've cleaned up the spaces and capitalization here a bit.

> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 36:
> 
>> 34: #include "code/nativeInst.hpp"
>> 35: #include "code/vtableStubs.hpp"
>> 36: #include "compiler/disassembler.hpp"
> 
> Redundant includes? No new code added in the file.

Good catch. Seems like a merge artifact maybe. Removing them seems to be fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7959