RFR: 8283689: Update the foreign linker VM implementation [v17]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri May 13 20:50:46 UTC 2022


On Fri, 13 May 2022 19:59:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 933:
>> 
>>> 931:     } else {
>>> 932:       assert(dst.is_single_reg(), "not a stack pair: (%s, %s), (%s, %s)",
>>> 933:         src.first()->name(), src.second()->name(), dst.first()->name(), dst.second()->name());
>> 
>> Still not indented properly.
>
> Shouldn't there be a 2-space indentation wrt the assert here? I could also indent all the arguments to be aligned with the format string, if that seems better.

It's preferred to indent multi-line argument lists on the column where argument list starts.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7959


More information about the hotspot-compiler-dev mailing list