RFR: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest [v3]
Vladimir Kozlov
kvn at openjdk.java.net
Sun May 15 15:27:46 UTC 2022
On Fri, 13 May 2022 04:08:37 GMT, Dean Long <dlong at openjdk.org> wrote:
>> This test was failing because the safepoint polling stub was only saving the low 8 bytes of XMM16-XMM31. We need to save all 16 bytes by default. I also added "wide" to the boolean parameter name to better reflect what it controls. And I made the asserts in save_live_registers() match what we have in restore_live_registers().
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>
> save_vectors --> save_wide_vectors
I agree with option 1) but may be save whole 512 bits unconditionally with comment explaining that we need to save 128 bits but it requires avx512vl support which is not available on all CPUs. We do have space for that anyway (i*64).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8690
More information about the hotspot-compiler-dev
mailing list