RFR: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest [v4]

Vladimir Ivanov vlivanov at openjdk.java.net
Mon May 16 20:27:34 UTC 2022


On Mon, 16 May 2022 20:10:29 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This test was failing because the safepoint polling stub was only saving the low 8 bytes of XMM16-XMM31.  We need to save all 16 bytes by default.  I also added "wide" to the boolean parameter name to better reflect what it controls.  And I made the asserts in save_live_registers() match what we have in restore_live_registers().
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Just do full 512-bit memory accesses when -XX:+UseKNLSetting is set

Still looks good. I prefer option #1 as well.

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8690


More information about the hotspot-compiler-dev mailing list