RFR: 8263075: C2: simplify anti-dependence check in PhaseCFG::implicit_null_check() [v2]

Brian J. Stafford duke at openjdk.java.net
Tue May 17 20:19:16 UTC 2022


On Tue, 17 May 2022 16:33:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Brian J. Stafford has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Removed whitespace
>>  - Added braces for if statements
>
> src/hotspot/share/opto/lcm.cpp line 344:
> 
>> 342:        }
>> 343:        if (k < num_nodes)
>> 344:          continue;             // Found anti-dependent load
> 
> Our code style requires to use {} for `if() {}`. the same for `if` at line 340.
> When we fixing code we fix its style too if it was wrong.

Thank you for pointing this out @vnkozlov, I've updated those if statements.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8684


More information about the hotspot-compiler-dev mailing list