RFR: 8286847: Rotate vectors don't support byte or short [v3]

Xiaohong Gong xgong at openjdk.java.net
Thu May 19 01:51:41 UTC 2022


On Wed, 18 May 2022 07:00:53 GMT, Haomin <duke at openjdk.java.net> wrote:

>> src/hotspot/share/opto/vectornode.cpp line 158:
>> 
>>> 156:     default:     return 0; // RotateLeftV for byte, short values produces incorrect Java result.
>>> 157:                            // Because java code should convert a byte, short value into int value,
>>> 158:                            // and then do RotateI.
>> 
>> I‘m afraid this will influence the VectorAPI intrinsification for `ByteVector `and `ShortVector`. Did you test the benchmarks for these two APIs with the subword type?
>
> I have tested `hotspot_vector_1` and `jdk_vector`, all pass.

Do you mean the benchmarks? Currently the vectorapi benchmarks only exist on panama-vector, please see: https://github.com/openjdk/panama-vector/tree/vectorIntrinsics/test/micro/org/openjdk/bench/jdk/incubator/vector/operation

-------------

PR: https://git.openjdk.java.net/jdk/pull/8740


More information about the hotspot-compiler-dev mailing list