RFR: 8286972: Support the new loop induction variable related PopulateIndex IR node on x86 [v2]

Vladimir Kozlov kvn at openjdk.java.net
Thu May 19 02:42:39 UTC 2022


On Thu, 19 May 2022 00:44:42 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment resolution
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 2278:
> 
>> 2276: 
>> 2277: void C2_MacroAssembler::vpadd(BasicType elem_bt, XMMRegister dst, XMMRegister src1, XMMRegister src2, int vlen_enc) {
>> 2278:   assert(UseAVX >= 2, "required");
> 
> Why not include this line in #ifdef ?

It does not matter since it is assert which add code only in debug VM. I like this way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8778


More information about the hotspot-compiler-dev mailing list