RFR: 8286972: Support the new loop induction variable related PopulateIndex IR node on x86 [v3]

Sandhya Viswanathan sviswanathan at openjdk.java.net
Fri May 20 04:50:01 UTC 2022


On Fri, 20 May 2022 01:57:04 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove warmup
>>  - Add jtreg test
>
> test/hotspot/jtreg/compiler/vectorization/TestPopulateIndex.java line 29:
> 
>> 27: * @requires vm.compiler2.enabled
>> 28: * @requires vm.cpu.features ~= ".*avx2.*"
>> 29: * @requires os.arch=="amd64" | os.arch=="x86_64"
> 
> Can we simplify `os.arch=="amd64" | os.arch=="x86_64"` to `os.simpleArch == "x64"` ?
> 
> This test runs on x86 only. It would be nice if it can run on AArch64 as well. So perhaps something like
> 
>  28 * @requires (os.simpleArch == "x64" & vm.cpu.features ~= ".*avx2.*") |
>  29 *           (os.simpleArch == "aarch64" & vm.cpu.features ~= ".*sve.*")

@pfustc  Yes, changed the requires to as suggested by you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8778


More information about the hotspot-compiler-dev mailing list