RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v7]
Jatin Bhateja
jbhateja at openjdk.java.net
Fri May 20 09:51:27 UTC 2022
On Thu, 19 May 2022 21:19:49 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - 8284960: Changes to enable jdk.incubator.vector to be treated as preview participant. Code re-organization related to Reverse/ReverseByte IR transforms.
>> - 8284960: Adding --enable-preview in vectorAPI benchmarks.
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - 8284960: Review comments resolution.
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - 8284960: Correcting a typo.
>> - 8284960: Integrating changes from panama-vector (Add @since 19 tags).
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8284960
>> - ... and 6 more: https://git.openjdk.java.net/jdk/compare/9f562ef7...311f3233
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Preview.java line 50:
>
>> 48: import java.util.Set;
>> 49:
>> 50: import static com.sun.tools.javac.code.Flags.PREVIEW_API;
>
> Suggestion:
>
>
> Redundant import (sorry i should have checked before i sent you updates to this area)
Merged
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Preview.java line 132:
>
>> 130: * @return true if {@code s} is participating in the preview of {@code previewSymbol}
>> 131: */
>> 132: public boolean isPreviewParticipating(Symbol s, Symbol previewSymbol) {
>
> Some feedback from a colleague:
> Suggestion:
>
> /**
> * Returns true if {@code s} is deemed to participate in the preview of {@code previewSymbol}, and
> * therefore no warnings or errors will be produced.
> *
> * @param s the symbol depending on the preview symbol
> * @param previewSymbol the preview symbol marked with @Preview
> * @return true if {@code s} is participating in the preview of {@code previewSymbol}
> */
> public boolean participatesInPreview(Symbol s, Symbol previewSymbol) {
Merged.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8425
More information about the hotspot-compiler-dev
mailing list