RFR: 8286847: Rotate vectors don't support byte or short [v3]

Xiaohong Gong xgong at openjdk.java.net
Mon May 23 09:04:02 UTC 2022


On Fri, 20 May 2022 07:12:59 GMT, Haomin <duke at openjdk.java.net> wrote:

>> yes, just  cherry-pick  my patch. And I just build the latest vectorIntrinsics branch, also met the error.
>
> -      CFLAGS_WARNINGS_ARE_ERRORS="-Werror"
> +      CFLAGS_WARNINGS_ARE_ERRORS=""
> ...
> -  JAVA_WARNINGS_ARE_ERRORS ?= -Werror
> +  JAVA_WARNINGS_ARE_ERRORS ?= 
> ...
> 
> with the dirty diff, I have tested Byte128Vector.
> Yes, the Score about rotate is lower than before my patch.
> Could you give me some suggestions?

Since `"VectorNode::implemented"` is only used for auto-vect, I think we can do the check in `"VectorNode::is_vector_rotate_supported" `and return false for byte and short type.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8740


More information about the hotspot-compiler-dev mailing list