RFR: 8287139: aarch64 intrinsic for unsignedMultiplyHigh

Nick Gasson ngasson at openjdk.java.net
Mon May 23 12:46:49 UTC 2022


On Mon, 23 May 2022 11:59:02 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:

> Adds aarch64 intrinsic support for `Math.unsignedMultiplyHigh()`

Looks fine apart from the tiny cosmetic issue. Did you try the `MathBench.unsignedMultiplyHighLongLong` JMH benchmark introduced with the x86 implementation?

src/hotspot/cpu/aarch64/aarch64.ad line 11151:

> 11149: 
> 11150:   ins_cost(INSN_COST * 7);
> 11151:   format %{ "umulh   $dst, $src1, $src2, \t# umulhi" %}

There's an unnecessary trailing comma here and in the `smulh` pattern above.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8840


More information about the hotspot-compiler-dev mailing list