RFR: 8287169: compiler/arguments/TestCompileThresholdScaling.java fails on x86_32 after JDK-8287052

Vladimir Kozlov kvn at openjdk.java.net
Mon May 23 18:15:50 UTC 2022


On Mon, 23 May 2022 17:03:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug report, recent regression. I believe the code makes the unwarranted assumption that we run on 64-bit platform, and thus caps at > 2^63 only. It should also cap at > 2^31 for 32-bit platforms.
> 
> Attn @dean-long.
> 
> Testing:
>  - [x] Affected test on Linux x86_64 fastdebug (still passes)
>  - [x] Affected test on Linux x86_32 fastdebug (now passes)

src/hotspot/share/compiler/compilerDefinitions.cpp line 139:

> 137:     int exp;
> 138:     (void) frexp(v, &exp);
> 139:     if (exp > LP64_ONLY(63) NOT_LP64(31)) {

How about `(exp > (sizeof(intx)*BitsPerByte-1))`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8851


More information about the hotspot-compiler-dev mailing list