RFR: 8283894: Intrinsify compress and expand bits on x86 [v6]

Paul Sandoz psandoz at openjdk.java.net
Mon May 23 22:32:53 UTC 2022


On Mon, 23 May 2022 09:27:04 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Summary of changes:
>> 
>> - Patch intrinsifies following newly added Java SE APIs
>>   - Integer.compress
>>   - Integer.expand
>>   - Long.compress
>>   - Long.expand
>>   
>> - Adds C2 IR nodes and corresponding ideal transformations for new operations.
>> - We see around ~10x performance speedup due to intrinsification over X86 target. 
>> - Adds an IR framework based test to validate newly introduced IR transformations.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8283894
>  - 8283894: Removing CompressExpandSanityTest from problem list.
>  - 8283894: Updating test tag spec.
>  - 8283894: Review comments resolved.
>  - 8283894: Add missing -XX:+UnlockDiagnosticVMOptions.
>  - 8283894: Review comments resolutions.
>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8283894
>  - 8283894: Extending IR framework testcase with some functional test points.
>  - 8283894: Intrinsify compress and expand bits on x86

test/jdk/java/lang/CompressExpandSanityTest.java line 29:

> 27:  * @key randomness
> 28:  * @run testng/othervm -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_expand_i,_expand_l,_compress_i,_compress_l CompressExpandSanityTest
> 29:  * @run testng CompressExpandSanityTest

Can we comment out the annotations so this test is not run by default (i don't know of a better way)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8498


More information about the hotspot-compiler-dev mailing list