RFR: 8284404: Too aggressive sweeping with Loom

Erik Österlund eosterlund at openjdk.java.net
Tue May 24 15:11:49 UTC 2022


On Tue, 24 May 2022 14:23:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > @vnkozlov Is your concern that a user explicitly overrides the default to a value that ends up not being good? If so, I'm not sure why we would be in the business of preventing the user from shooting itself in the foot and guessing what the user really wanted here. Maybe I missed something.
> 
> 
> 
> Yes, it was my concern which was unjustifiable because I missed that this code is guarded by `FLAG_IS_DEFAULT(SweeperThreshold)`. So you simply set `SweeperThreshold` to 5% (default is 0.5) which is fine.

Okay great - thanks for the review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8673


More information about the hotspot-compiler-dev mailing list