RFR: 8285868: x86 intrinsics for floating point methods isNaN, isFinite and isInfinite [v9]

Srinivas Vamsi Parasa duke at openjdk.java.net
Tue May 24 22:09:16 UTC 2022


On Tue, 24 May 2022 22:00:20 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> I assume `Baseline` data includes #8525 changes. Right?

Yes, the basline data includes #8525 changes.

> Looks good.
> 
> Please, adopt @merykitty suggested changes for micro-benchmarks to include `store, cmove, branch` cases. Show performance results for all of them.
> 
> Also adapt your regression tests for all 3 cases too.

Sure, I will update the microbenchmarks to include `store, cmove, branch` cases and post the performance data.

> src/hotspot/share/runtime/vmStructs.cpp line 1847:
> 
>> 1845:   declare_c2_type(SignumDNode, Node)                                      \
>> 1846:   declare_c2_type(SignumFNode, Node)                                      \
>> 1847:   declare_c2_type(IsInfiniteFNode, Node)                                  \
> 
> Where are other new nodes?

I did not know how to combine the 3 nodes into one. Could you pls give few pointers to refer to for implementing them?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8459


More information about the hotspot-compiler-dev mailing list