RFR: 8283894: Intrinsify compress and expand bits on x86 [v7]

[Paul Sandoz]

On Wed, 25 May 2022 06:20:43 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Summary of changes:
>> 
>> - Patch intrinsifies following newly added Java SE APIs
>>   - Integer.compress
>>   - Integer.expand
>>   - Long.compress
>>   - Long.expand
>>   
>> - Adds C2 IR nodes and corresponding ideal transformations for new operations.
>> - We see around ~10x performance speedup due to intrinsification over X86 target. 
>> - Adds an IR framework based test to validate newly introduced IR transformations.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8283894: Disabling sanity test as per review suggestion.

test/jdk/java/lang/CompressExpandSanityTest.java line 29:

> 27:  * //@key randomness
> 28:  * //@run testng/othervm -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_expand_i,_expand_l,_compress_i,_compress_l CompressExpandSanityTest
> 29:  * //@run testng CompressExpandSanityTest

Suggestion:

// Disabled by default
// @test
/*
 * @summary Test compress expand as if the test methods are the implementation methods
 * @key randomness
 * @run testng/othervm -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_expand_i,_expand_l,_compress_i,_compress_l CompressExpandSanityTest
 * @run testng CompressExpandSanityTest
 */

I think we need to do it like above, otherwise it will induce a test error

-------------

PR: https://git.openjdk.java.net/jdk/pull/8498