RFR: 8287223: C1: Inlining attempt through MH::invokeBasic() with null receiver [v3]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri May 27 20:41:36 UTC 2022


On Wed, 25 May 2022 23:01:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Redundant import
>
> src/hotspot/share/opto/callGenerator.cpp line 1021:
> 
>> 1019:       if (receiver->Opcode() == Op_ConP) {
>> 1020:         input_not_const = false;
>> 1021:         ciObject* recv_obj = receiver->bottom_type()->is_oopptr()->const_oop();
> 
> In general ConP could be `NULL_PTR` (AnyPtr). I think you need to use `isa_oopptr()` and check for `NULL` here.
> Or it can't be `NULL_PTR` in this case?

Good catch, Vladimir. I fixed the code and enhanced the test to exercise problematic case by C2.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8894


More information about the hotspot-compiler-dev mailing list