RFR: 8286990: Add compiler name to warning messages in Compiler Directive [v2]

Cesar Soares duke at openjdk.java.net
Sun May 29 00:07:25 UTC 2022


On Tue, 24 May 2022 04:34:54 GMT, Yuta Sato <duke at openjdk.java.net> wrote:

>> When using Compiler Directive such as `java -XX:+UnlockDiagnosticVMOptions -XX:CompilerDirectivesFile=<CompilerDirectives.json> <Java.class>` ,
>> it shows totally the same message for c1 and c2 compiler and the user would be confused about 
>> which compiler is affected by this message.
>> This should show messages with their compiler name so that the user knows which compiler shows this message.
>> 
>> My change result would be like the below.
>> 
>> 
>> OpenJDK 64-Bit Server VM warning: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> OpenJDK 64-Bit Server VM warning: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> 
>> ->
>> 
>> OpenJDK 64-Bit Server VM warning: c1: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> OpenJDK 64-Bit Server VM warning: c2: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>
> Yuta Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update full name

src/hotspot/share/compiler/compilerDirectives.hpp line 131:

> 129:   static ccstrlist canonicalize_control_intrinsic(ccstrlist option_value);
> 130:   void finalize(outputStream* st);
> 131:   bool is_c1(CompilerDirectives* directive);

NIT: these methods can be made "const".

-------------

PR: https://git.openjdk.java.net/jdk/pull/8591


More information about the hotspot-compiler-dev mailing list