RFR: JDK-8287349: AArch64: Merge LDR instructions to improve C1 OSR performance [v2]

Zhuojun Miao zmiao at openjdk.java.net
Tue May 31 07:55:30 UTC 2022


On Sat, 28 May 2022 06:41:33 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Zhuojun Miao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8287349
>>  - use ldp explicitly
>>  - JDK-8287349: Merge LDR instructions to improve C1 OSR performance
>
> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 288:
> 
>> 286:       __ ldr(r20, Address(OSR_buf, slot_offset + 1*BytesPerWord));
>> 287:       __ str(r19, frame_map()->address_for_monitor_lock(i));
>> 288:       __ str(r20, frame_map()->address_for_monitor_object(i));
> 
> I think it would be better to use `ldp` explicitly here, rather than relying on the assembler to do the merge.

OK.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8933


More information about the hotspot-compiler-dev mailing list