RFR: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong

[Christian Hagedorn]

On Tue, 1 Nov 2022 17:09:55 GMT, Dhamoder Nalla <duke at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8286800
>> 
>> assert(real_LCA != NULL) in dump_real_LCA is not appropriate in bad graph scenario when both wrong_lca & early nodes are start nodes
>> 
>> jvm!PhaseIdealLoop::dump_real_LCA():
>> // Walk the idom chain up from early and wrong_lca and stop when they intersect.
>> while (!n1->is_Start() && !n2->is_Start()) {
>> ...
>> }
>> assert(real_LCA != NULL, "must always find an LCA");
>> 
>> Fix: replace assert with a console message
>
>> 
> 
> Thanks @chhagedorn, please take this over as you are already familiar with this area.

Hi @dhanalla, okay, I'll do that. Thanks for letting me know!

-------------

PR: https://git.openjdk.org/jdk/pull/10472