RFR: JDK-8290063: IGV: Give the graphs a unique number in the outline [v2]

Tobias Holenstein tholenstein at openjdk.org
Wed Nov 2 16:01:31 UTC 2022


On Wed, 2 Nov 2022 15:28:15 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - missing imports
>>  - added RenameAction with shortcut
>
> Nice improvement! Works as expected - looks good to me.

Thanks @chhagedorn and @TobiHartmann for the reviews!

> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/FolderNode.java line 156:
> 
>> 154:         children.getFolder().setName(name);
>> 155:         fireDisplayNameChange(null, null);
>> 156:     }
> 
> Missing new line

fixed

> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/GraphNode.java line 65:
> 
>> 63:         graph.setName(name);
>> 64:         fireDisplayNameChange(null, null);
>> 65:     }
> 
> Missing new line

fixed

-------------

PR: https://git.openjdk.org/jdk/pull/10873


More information about the hotspot-compiler-dev mailing list