RFR: 8296168: x86: Add reasonable constraints between AVX and SSE [v2]

Claes Redestad redestad at openjdk.org
Wed Nov 2 21:49:53 UTC 2022


On Wed, 2 Nov 2022 17:19:27 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove redundant SSE < 0 check
>>  - Remove redundant AVX < 0 check, revert narrow supports_sse4_1 check
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 905:
> 
>> 903:     warning("UseSSE=%d is not supported on this CPU, setting it to UseSSE=%d", (int) UseSSE, use_sse_limit);
>> 904:     FLAG_SET_DEFAULT(UseSSE, use_sse_limit);
>> 905:   } else if (UseSSE < 0) {
> 
> `UseSSE < 0` check is redundant since the flag is already constrained to `[0..99]` range.

Fixed. (Should such ranges be narrowed down to the actual values supported?)

-------------

PR: https://git.openjdk.org/jdk/pull/10946


More information about the hotspot-compiler-dev mailing list