RFR: 8296168: x86: Add reasonable constraints between AVX and SSE [v2]
Vladimir Kozlov
kvn at openjdk.org
Wed Nov 2 22:03:24 UTC 2022
On Wed, 2 Nov 2022 21:49:52 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> We've not seen any x86 CPU, Intel or otherwise, where AVX features are available but SSE 4.1 is not supported. This patch suggests constraining setup so that any explicit value of UseSSE less than 4 (the default on any AVX-supporting CPU) implicitly disables AVX. This simplifies ergonomics and reduces the testing surface. Concretely this would allow #10847 to not have to guard the new intrinsic on UseSSE level to avoid some surprising test failures in tests verifying SSE-enabled intrinsics.
>>
>> I've rearranged the initialization of UseAVX and UseSSE to allow AVX to look at the post-ergo values of UseSSE.
>>
>> Testing: tier1-tier3, manual verification
>
> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove redundant SSE < 0 check
> - Remove redundant AVX < 0 check, revert narrow supports_sse4_1 check
This looks good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10946
More information about the hotspot-compiler-dev
mailing list