RFR: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics [v2]
Yi-Fan Tsai
duke at openjdk.org
Thu Nov 3 00:33:28 UTC 2022
On Thu, 3 Nov 2022 00:19:03 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:
>> Increase WARMUP_ITERATIONS to get MD5 hash from the intrinsic.
>>
>> Both TestMD5Intrinsics and TestMD5MultiBlockIntrinsics are run with options "-XX:CompileThreshold=500 -XX:Tier4InvocationThreshold=500", so the current value is too low for the intrinsic to be executed.
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>
> Set WARMUP_ITERATIONS based on Tier4InvocationThreshold
The verifier detects the intrinsic compiled/inlined somewhere, but it doesn't get executed. In other words, the verifier alone didn't guarantee the intrinsic tested.
WARMUP_ITERATIONS is now set strictly larger than Tier4InvocationThreshold.
Both TestMD5Intrinsics and TestMD5MultiBlockIntrinsics are run with `-Xbatch`.
-------------
PR: https://git.openjdk.org/jdk/pull/10954
More information about the hotspot-compiler-dev
mailing list