RFR: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> [v3]

Olga Mikhaltsova omikhaltcova at openjdk.org
Sun Nov 6 21:02:17 UTC 2022


> This PR is opened as a follow-up for [1] and included the "must-done" fixes pointed by @teshull.
> 
> This patch for JVMCI includes the following fixes related to the macOS AArch64 calling convention:
> 1. arguments may consume slots on the stack that are not multiples of 8 bytes [2]
> 2. natural alignment of stack arguments [2]
> 3. stack must remain 16-byte aligned [3][4]
> 
> Tested with tier1 on macOS AArch64 and Linux AArch64.
> 
> [1] https://github.com/openjdk/jdk/pull/6641
> [2] https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
> [3] https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-160#stack
> [4] https://docs.microsoft.com/en-us/cpp/build/stack-usage?view=msvc-170

Olga Mikhaltsova has updated the pull request incrementally with one additional commit since the last revision:

  Refactoring

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10238/files
  - new: https://git.openjdk.org/jdk/pull/10238/files/6f8b3215..8b9922a2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10238&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10238&range=01-02

  Stats: 17 lines in 4 files changed: 4 ins; 7 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/10238.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10238/head:pull/10238

PR: https://git.openjdk.org/jdk/pull/10238


More information about the hotspot-compiler-dev mailing list