RFR: 8296805: ctw build is broken

Vladimir Kozlov kvn at openjdk.org
Thu Nov 10 18:18:23 UTC 2022


On Thu, 10 Nov 2022 18:08:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> I noticed the build for the ctw tool based on the WhiteBox API is
>> broken. This fixes it AFAICT.
>
> test/hotspot/jtreg/testlibrary/ctw/Makefile line 50:
> 
>> 48:     $(TESTLIBRARY_DIR)/jtreg \
>> 49:     -maxdepth 1 -name '*.java')
>> 50: WB_SRC_FILES = $(shell find $(TESTLIBRARY_DIR)/jdk/test/lib/compiler $(TESTLIBRARY_DIR)/jdk/test/whitebox -name '*.java')
> 
> I think `$(TESTLIBRARY_DIR)/sun/hotspot` should be removed.
> [JDK-8067223](https://bugs.openjdk.org/browse/JDK-8067223) left copy of WB there because some tests were still using it. But recent @coleenp changes [JDK-8271707](https://bugs.openjdk.org/browse/JDK-8271707) and followed [JDK-8275662](https://bugs.openjdk.org/browse/JDK-8275662) removed duplicated WB in `sun/hotspot`.

NM that. I looked on description in JBS and saw that you need CompilerUtils.java which is in `jdk/test/lib/compiler`.
I will run our internal testing.

-------------

PR: https://git.openjdk.org/jdk/pull/11090


More information about the hotspot-compiler-dev mailing list