Integrated: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
Olga Mikhaltsova
omikhaltcova at openjdk.org
Thu Nov 10 21:09:03 UTC 2022
On Mon, 12 Sep 2022 14:35:30 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:
> This PR is opened as a follow-up for [1] and included the "must-done" fixes pointed by @teshull.
>
> This patch for JVMCI includes the following fixes related to the macOS AArch64 calling convention:
> 1. arguments may consume slots on the stack that are not multiples of 8 bytes [2]
> 2. natural alignment of stack arguments [2]
> 3. stack must remain 16-byte aligned [3][4]
>
> Tested with tier1 on macOS AArch64 and Linux AArch64.
>
> [1] https://github.com/openjdk/jdk/pull/6641
> [2] https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
> [3] https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-160#stack
> [4] https://docs.microsoft.com/en-us/cpp/build/stack-usage?view=msvc-170
This pull request has now been integrated.
Changeset: 6b456f7a
Author: Olga Mikhaltsova <omikhaltcova at openjdk.org>
Committer: Anton Kozlov <akozlov at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6b456f7a9b6344506033dfdc5a59c0f3e95c4b2a
Stats: 112 lines in 8 files changed: 100 ins; 6 del; 6 mod
8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
Reviewed-by: aph
-------------
PR: https://git.openjdk.org/jdk/pull/10238
More information about the hotspot-compiler-dev
mailing list